Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added files to testing directory #23

Merged
merged 2 commits into from
Feb 22, 2024
Merged

Added files to testing directory #23

merged 2 commits into from
Feb 22, 2024

Conversation

LaniW
Copy link
Contributor

@LaniW LaniW commented Feb 22, 2024

No description provided.

Copy link
Contributor Author

@LaniW LaniW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request contains the following:

  • Directory structure specifically made for testing
  • Java files containing untested JUnit tests due to a VSCode error

@LaniW
Copy link
Contributor Author

LaniW commented Feb 22, 2024

Ongoing List of Things Of Note for Testing

  • Account.java: The Transactions class cannot be instantiated so it may not be possible to test transactions within the account.
  • Deck.java: The deck tests assume that the size of the maindeck will vary from deck to deck.
  • Slots.java: All payouts are all private static variables so they might not be accessible for testing purposes.
  • Transaction.java: It would be nice to make a method to return the amountSent for testing purposes. The testing file is empty because it is a protected value and there is not much else to test here.
  • Deposit.java: It extends Transaction which was not testable by the protected values so it also contains an empty file.
  • Payment.java: Contains a setUp method with a sender and receiver. Still, since it utilizes transactions with protected values it cannot access attributes like the amountSent which would verify the payment made. There are no Assertions listed as a result.
  • Withdrawl.java: Similar to any other file extending Transaction, the protected values cannot be accessed so a withdrawal cannot be verified.

@evanrcooper evanrcooper self-assigned this Feb 22, 2024
@evanrcooper evanrcooper merged commit cde5640 into main Feb 22, 2024
@evanrcooper evanrcooper deleted the feat/unit-tests branch February 22, 2024 19:38
@secureshellprotocol secureshellprotocol linked an issue Feb 26, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unit tests for implemented classes
3 participants